Remove unused options passed to proc_open() (Windows only)#62
Merged
jsor merged 1 commit intoreactphp:masterfrom Nov 25, 2018
Merged
Remove unused options passed to proc_open() (Windows only)#62jsor merged 1 commit intoreactphp:masterfrom
jsor merged 1 commit intoreactphp:masterfrom
Conversation
Member
|
With limited windows support coming back in |
Member
Author
|
@WyriHaximus Valid point! This is something I have prepared and will look into in a follow-up PR. This PR is a preparation for this and removes these options simply because they provide no value whatsoever currently. They may be re-introduced in one of the follow-up PRs with some proper tests/documentation to veriify correct execution on Windows 👍 |
WyriHaximus
approved these changes
Nov 24, 2018
Member
WyriHaximus
left a comment
There was a problem hiding this comment.
@clue sounds good to me 👍
jsor
approved these changes
Nov 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR removes the unused options passed to
proc_open(). These options only affect behavior on Windows (suppress_errorsandbypass_shelloptions) which is currently not supported anyway (#9). They are not documented or referenced anywhere else in this library anyway, so while this may technically be a BC break, its actual impact should be relatively small.